On Tue, Apr 17, 2018 at 03:57:07PM +0800, Chen-Yu Tsai wrote: > >> @@ -697,6 +700,8 @@ static int __init sunxi_mc_smp_init(void) > >> break; > >> } > >> > >> + is_sun8i = sunxi_mc_smp_data[i].is_sun8i; > >> + > > > > Do we really need to cache it? Can't we just have a pointer to the SMP > > data structure and use that instead? > > I recommended that. We don't need any of the other fields in the SMP > data structure once we're past the init phase. This saves a dereference > or two. Fair enough. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature