On 04/15/2018 06:15 PM, Pavel Machek wrote: > Hi! > >>>> A case I care about is I have a family of boards that all have a >>>> common defined set of 4 LEDs. They could be driven by anything, but I >>>> want the same interface presented to userspace across boards. >>>> " >>> >>> Yes, and "label" should provide me with that ability as the context >>> was the practice of putting the controller name in the label. >> >> Exactly. There are two options: >> >> 1. >> - label format : "<color>:<function" >> 2. >> - label format : "<function>" >> - new "color" DT property > > We should provide compatibility here. > > So we should really have new "color" property, and probably new > "function" property, too. > >> The changes in dts files would have to be accompanied by changes in >> DT parsing part of LED class drivers. Also, I wonder if it wouldn't >> make sense to add config option to choose between old and new LED >> naming convention to avoid userspace breakage. > > Both old and new kernels are expected to be working with both old and > new dts... > > And having config option choosing userland interfaces would not be nice. Agreed. So the naming pattern will be chosen basing on whether there is 'label' property available or the 'function' and 'color' ones. >> It would allow to use dts files with old style labels with >> newer kernels. The LED class device names would differ like below: >> >> Old style name (current): >> /sys/class/leds/netxbig:red:power >> >> New style name: >> /sys/class/leds/red:power (we could also think of dropping >> color from name and adding sysfs >> file for it) > > I believe color needs to stay: it is common to have "green:battery" > for "battery ok" and "yellow:battery" for charging, for > example. Notification LED has three channels, "red", "green", > "blue"... I don't have a strong opinion on that, so ack. > Thanks for looking into this, Thanks for the feedback. I'll try to come up with an initial patchset when I'll find a moment. -- Best regards, Jacek Anaszewski
Attachment:
signature.asc
Description: OpenPGP digital signature
