Hi Andy, Just a very minor nit. On 8 February 2018 at 09:18, Andy Yan <andy.yan@xxxxxxxxxxxxxx> wrote: [..] > + > +static int get_if_type(struct rockchip_sfc *sfc, enum spi_nor_protocol proto) > +{ I understand that this got copy-pasted from some other driver, but please change this function name to something like rockchip_sfc_get_if_type(). Thanks, Eze -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html