Hi Rob,
On 09/04/2018 20:12, Rob Herring wrote:
> On Wed, Mar 28, 2018 at 12:38:33PM +0100, Gustavo Pimentel wrote:
>> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@xxxxxxxxxxxx>
>> ---
>> Documentation/devicetree/bindings/pci/designware-pcie.txt | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/designware-pcie.txt b/Documentation/devicetree/bindings/pci/designware-pcie.txt
>> index 6300762..4bb2e08 100644
>> --- a/Documentation/devicetree/bindings/pci/designware-pcie.txt
>> +++ b/Documentation/devicetree/bindings/pci/designware-pcie.txt
>> @@ -3,6 +3,7 @@
>> Required properties:
>> - compatible:
>> "snps,dw-pcie" for RC mode;
>> + "snps,dw-pcie-ep" for EP mode;
>> - reg: Should contain the configuration address space.
>> - reg-names: Must be "config" for the PCIe configuration space.
>> (The old way of getting the configuration address space from "ranges"
>> @@ -56,3 +57,15 @@ Example configuration:
>> #interrupt-cells = <1>;
>> num-lanes = <1>;
>> };
>> +or
>> + pcie_ep: pcie_ep@dfc00000 {
>
> pcie-ep@...
>
> Or what others have used. We should define a standard name in the DT
> spec for this.
>
By looking to [1] and [2], I think I should maintain the pcie name instead of
pcie-ep.
[1] ->
https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/pci/ti-pci.txt
[2] ->
https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/pci/axis,artpec6-pcie.txt
Thanks for noticing it.
>> + compatible = "snps,dw-pcie-ep";
>> + reg = <0xdfc00000 0x0001000>, /* IP registers 1 */
>> + <0xdfc01000 0x0001000>, /* IP registers 2 */
>> + <0xd0000000 0x2000000>; /* Configuration space */
>> + reg-names = "dbi", "dbi2", "addr_space";
>> + device_type = "pci";
>> + num-ib-windows = <6>;
>> + num-ob-windows = <2>;
>> + num-lanes = <1>;
>> + };
>> --
>> 2.7.4
>>
>>
Regards,
Gustavo
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
