Re: [PATCH] arm64: dts: juno: drop unnecessary address-cells and size-cells properties

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 09, 2018 at 04:09:20PM +0100, Sudeep Holla wrote:
> /smb@8000000/motherboard/gpio_keys node doesn't have "ranges" or "reg"
> property in child nodes. So it's unnecessary to have address-cells
> as well as size-cells properties which results in below warning.
> 
> Warning (avoid_unnecessary_addr_size):
> /smb@8000000/motherboard/gpio_keys:
> 	unnecessary #address-cells/#size-cells without "ranges" or child "reg"
> 	property
> 
> This patch drops the unnecessary address+size-cell properties.
> 
> Cc: Liviu Dudau <liviu.dudau@xxxxxxx>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
> Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>

Looks like the sensible thing to do!

Reviewed-by: Liviu Dudau <liviu.dudau@xxxxxxx>

Best regards,
Liviu

> ---
>  arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 2 --
>  1 file changed, 2 deletions(-)
> 
> (Missed cc-ed people earlier)
> 
> diff --git a/arch/arm64/boot/dts/arm/juno-motherboard.dtsi b/arch/arm64/boot/dts/arm/juno-motherboard.dtsi
> index 2ac43221ddb6..69804c5f1197 100644
> --- a/arch/arm64/boot/dts/arm/juno-motherboard.dtsi
> +++ b/arch/arm64/boot/dts/arm/juno-motherboard.dtsi
> @@ -56,8 +56,6 @@
> 
>  			gpio_keys {
>  				compatible = "gpio-keys";
> -				#address-cells = <1>;
> -				#size-cells = <0>;
> 
>  				power-button {
>  					debounce_interval = <50>;
> --
> 2.7.4
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux