On Thu, Apr 5, 2018 at 7:14 PM, Oliver <oohall@xxxxxxxxx> wrote: > > On Fri, Apr 6, 2018 at 12:43 AM, Dan Williams <dan.j.williams@xxxxxxxxx> wrote: > > On Thu, Apr 5, 2018 at 5:43 AM, Oliver <oohall@xxxxxxxxx> wrote: > >> On Thu, Apr 5, 2018 at 10:11 PM, Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote: > >>> Oliver <oohall@xxxxxxxxx> writes: > >>> ... > >>>> > >>>> For context Balbir is working with me on some of the pmem stuff. You > >>>> probably want an Ack from Rob rather than one of us. > >>> > >>> I'll ack it if you make all the niggly nit picky trivial annoying > >>> changes I asked for :D > >> > >> *groan* > >> > >> Fine, I'll respin it tomorrow. If anyone else has comments now would > >> be the time to make them. > > > > Please also include my niggly nit picky trivial annoying bike shed > > color for the driver name to *not* use the "nd_region" suffix for a > > driver registering "nvdimm_bus" objects. "of_pmem_range" or > > "of_pmem_bus" or almost anything else would be fine. > > Oh sure, would using of_pmem_region to match the compatible be ok? That works for me. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html