> >> From: Stephen Warren <swarren@xxxxxxxxxx> > >> > >> Some boards or SoCs have an inverter between the PMIC IRQ output pin and > >> the IRQ controller input signal. > >> > >> The IRQ specifier in DT is meant to represent the IRQ flags at the input > >> to the IRQ controller. > >> > >> The Palmas HW's IRQ output has configurable polarity. The driver > >> currently selects the output polarity by querying the input polarity at > >> the IRQ controller. This works fine if the IRQ signal is routed directly > >> from the PMIC to the IRQ controller with no intervening logic. However, > >> if the signal is inverted between the two, this automatic polarity > >> selection gets the wrong answer. > >> > >> Add an additional optional DT and platform data parameter which indicates > >> that such an inversion occurs. If this option is enabled, the Palmas > >> driver will configure its IRQ output to the opposite polarity of the IRQ > >> controller's input. > >> > >> An alternative would have been to add a new non-optional DT parameter to > >> indicate the exact desired output polarity. However, this would have been > >> an incompatible change to the DT binding. > >> > >> Signed-off-by: Stephen Warren <swarren@xxxxxxxxxx> > >> --- > >> If this patch could be applied to its own branch (w/ signed tag) in the > >> MFD tree, that would great; then I can pull patch 1/2 into the Tegra tree > >> so that I can apply patch 2/2 to the Tegra tree. Thanks. > >> --- > >> Documentation/devicetree/bindings/mfd/palmas.txt | 6 ++++++ > >> drivers/mfd/palmas.c | 4 ++++ > >> include/linux/mfd/palmas.h | 1 + > >> 3 files changed, 11 insertions(+) > > > > For the core changes: > > Acked-by: Lee Jones <lee.jones@xxxxxxxxxx> > > Thanks. Since you ack'd this and are an MFD maintainer, was that an > indication that I should take this patch through the Tegra tree? No, it was an indication that we still require more Acks. :) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
