Re: [PATCH] mfd: dt-bindings: Add PMIC reset property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rob,

On 03/18/2018 01:52 PM, Rob Herring wrote:
On Thu, Mar 15, 2018 at 11:58:50AM +0100, Daniel Schultz wrote:
Add documentation about a new rk808 devicetree property, which can
enable resets by the PMIC.

The subject needs to be more specific that this is for Rockchip PMIC.


Signed-off-by: Daniel Schultz <d.schultz@xxxxxxxxx>
---
  Documentation/devicetree/bindings/mfd/rk808.txt | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/rk808.txt b/Documentation/devicetree/bindings/mfd/rk808.txt
index 91b6522..fa1a30f 100644
--- a/Documentation/devicetree/bindings/mfd/rk808.txt
+++ b/Documentation/devicetree/bindings/mfd/rk808.txt
@@ -20,6 +20,8 @@ Optional properties:
    default output clock name
  - rockchip,system-power-controller: Telling whether or not this pmic is controlling
    the system power.
+- rockchip,system-reset-controller: Telling whether or not this pmic is controlling
+  the system reset.

Would you ever really have power and reset controlled by different
things? IOW, why do we need 2 properties?

The existing property enables the shutdown function and since the preferred way for resetting the system is the soft reset (control and reset module), rockchip wishes to have an extra property.

--
Mit freundlichen Grüßen,
With best regards,
  Daniel Schultz
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux