Hi Geert, Thanks for the feedback. > Hi Biju, > > On Wed, Mar 28, 2018 at 3:13 PM, Biju Das <biju.das@xxxxxxxxxxxxxx> wrote: > >> On Tue, Mar 27, 2018 at 4:37 PM, Biju Das <biju.das@xxxxxxxxxxxxxx> > wrote: > >> > Add support for iWave iW-RainboW-G23S single board computer based > >> > on RZ/G1C. > >> > > >> > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > >> > Reviewed-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> > >> > >> Thanks for your patch! > >> > >> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > >> > >> One question below. > >> > >> > --- /dev/null > >> > +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts > >> > @@ -0,0 +1,30 @@ > >> > +// SPDX-License-Identifier: GPL-2.0 > >> > +/* > >> > + * Device Tree Source for the iWave-RZ/G1C single board computer > >> > + * > >> > + * Copyright (C) 2018 Renesas Electronics Corp. > >> > + */ > >> > + > >> > +/dts-v1/; > >> > +#include "r8a77470.dtsi" > >> > +/ { > >> > + model = "iWave iW-RainboW-G23S single board computer based > >> > +on > >> RZ/G1C"; > >> > + compatible = "iwave,g23s", "renesas,r8a77470"; > >> > + > >> > + aliases { > >> > + serial1 = &scif1; > >> > + }; > >> > >> No chosen / stdout-path? > > > > I am planning this later as part of ethernet patch submission. > > But stdout-path is not related to Ethernet? Ok. Will add stdout-path in V2. > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. But when > I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f