Hello Jacek,
On 27.03.18 23:58, Jacek Anaszewski wrote:
>> +Example
>> +-------
>> +
>> +led-controller@0 {
>> + compatible = "crane,cr0014114";
>> + reg = <0>;
>> + spi-max-frequency = <50000>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + led@0 {
>> + reg = <0>;
>> + label = "cr0:red:coin";
>> + };
>> + led@1 {
>> + reg = <1>;
>> + label = "cr0:green:coin";
>> + };
>> + led@2 {
>> + reg = <2>;
>> + label = "cr0:blue:coin";
>> + };
>> + led@3 {
>> + reg = <3>;
>> + label = "cr1:red:bill";
>> + };
>> + led@4 {
>> + reg = <4>;
>> + label = "cr1:green:bill";
>> + };
>> + led@5 {
>> + reg = <5>;
>> + label = "cr1:blue:bill";
>> + };
>
> Why cr0 and cr1? It should be cr0014114 to stick to the
> current LED naming pattern <devicename:colour:function>.
>
> Nonetheless, we lately came to the conclusion that devicename
> segment is redundant in LED class device name, so until we change
> LED naming convention officially, let's remove devicename segment
> at least from DT and prepend the label with "cr0014114" in the driver.
>
> Please compare how it is approached in [0] (not merged yet).
>
It's just example.
But anyway our applications works with LEDs by numbers.
Using function names instead numbers will increase code complexity,
so we use numbers :)
>> +};
>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
>> index ae850d6c0ad3..f17949c365f5 100644
>> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
>> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
>> @@ -75,6 +75,7 @@ cnxt Conexant Systems, Inc.
>> compulab CompuLab Ltd.
>> cortina Cortina Systems, Inc.
>> cosmic Cosmic Circuits
>> +crane Crane Connectivity Solutions
>> creative Creative Technology Ltd
>> crystalfontz Crystalfontz America, Inc.
>> cubietech Cubietech, Ltd.
>>
>
> [0] https://www.spinics.net/lists/devicetree/msg220561.html
>
--
Best regards,
Oleh Kravchenko
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
