> + } else if (slave->link_interface == RGMII_LINK_MAC_PHY) { > + has_phy = true; > + phy_mode = of_get_phy_mode(slave->node); > + /* if phy-mode is not present, default to > + * PHY_INTERFACE_MODE_RGMII > + */ > + if (phy_mode < 0) > + phy_mode = PHY_INTERFACE_MODE_RGMII; Can only do RGMII? Maybe add a call here to phy_interface_mode_is_rgmii() and return -EINVAL if DT contains something which is not RGMII? Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html