On Sat, Mar 24, 2018 at 03:32:05PM +0100, Linus Walleij wrote: > On Mon, Mar 12, 2018 at 4:52 PM, Charles Keepax > <ckeepax@xxxxxxxxxxxxxxxxxxxxx> wrote: > > > Now GPIOD has support for both pdata systems and for non-standard DT > > bindings the Arizona reset GPIO can be converted to use it. Worth > > noting gpiod_set_raw_value_cansleep is used to match the behaviour > > of the old GPIOs. This is because the part is fairly widely used and > > it is unknown how many DTs are correctly setting active low through > > device tree, so to avoid breaking any existing users it is best to > > match the previous behaviour. > > > > Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> > > --- > The use of gpiod_set_raw* should be done with caution, but this > is one of the cases where we need to take out the big hammer to > make sure things stay compatible. > > I haven't read why it is like so but I guess because the right flags > in the device tree can not be guaranteed? > Exactly yes there are a lot of these parts out there and since they never required the DT flags to be set correctly before I very much doubt all those DTs are set correctly. Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
