2014-02-17 15:10 GMT-08:00 Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>: > Hello. > > > On 02/14/2014 03:08 AM, Florian Fainelli wrote: > >> This patch adds the Device Tree bindings for the Broadcom GENET Gigabit >> Ethernet controller. A bunch of examples are provided to illustrate the >> versatile aspect of the hardare. > > >> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx> > > [...] > > Too bad I didn't read this patch before and now it has been already > applied. > > [...] > > >> diff --git a/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt >> b/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt >> new file mode 100644 >> index 0000000..afd31f9 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt >> @@ -0,0 +1,121 @@ >> +* Broadcom BCM7xxx Ethernet Controller (GENET) >> + >> +Required properties: >> +- compatible: should contain one of "brcm,genet-v1", "brcm,genet-v2", >> + "brcm,genet-v3", "brcm,genet-v4". >> +- reg: address and length of the register set for the device >> +- interrupts: must be two cells, the first cell is the general purpose >> + interrupt line, while the second cell is the interrupt for the ring >> + RX and TX queues operating in ring mode >> +- phy-mode: String, operation mode of the PHY interface. Supported values >> are >> + "mii", "rgmii", "rgmii-txid", "rev-mii", "moca". Analogous to ePAPR >> + "phy-connection-type" values >> +- address-cells: should be 1 >> +- size-cells: should be 1 > > > The above two prop names should have # in front of them. Examples seem to > be correct. Some words about the downstream bus wouldn't hurt too. Absolutely, let me follow up with a patch fixing this. > > [...] > >> +Required child nodes: >> + >> +- mdio bus node: this node should always be present regarless of the PHY >> + configuration of the GENET instance >> + >> +MDIO bus node required properties: >> + >> +- compatible: should contain one of "brcm,genet-mdio-v1", >> "brcm,genet-mdio-v2" >> + "brcm,genet-mdio-v3", "brcm,genet-mdio-v4", the version has to match >> the >> + parent node compatible property (e.g: brcm,genet-v4 pairs with >> + brcm,genet-mdio-v4) >> +- reg: address and length relative to the parent node base register >> address >> +- address-cells: address cell for MDIO bus addressing, should be 1 >> +- size-cells: size of the cells for MDIO bus addressing, should be 0 > > > The above two props should have # in front of them as well. Examples seem > to be correct. > > WBR, Sergei > -- Florian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
