On Thu, Mar 22, 2018 at 09:03:58AM +0800, Shawn Lin wrote: > [+ Greg] Why me? > > It would be OK for me to keep files separate too; a separate question > > would then be whether we have to rename drivers/pci/host if we add > > endpoint drivers in there, do we have to? > > > > At that stage we could well move drivers/pci/dwc and drivers/pci/cadence > > in there too. > > > > I add Greg to this thread, and hope he could shed a light here. > > That is completely the same situation annoying me when looking into > drivers/usb where they have drivers/usb/host/ for host drivers, > drivers/usb/gadget/ for device framwork, drivers/usb/gaget/udc for > device drivers, and even surprisingly drivers/usb/dwc2/, > drivers/usb/dwc3/ and drivers/usb/renesas_usbhs/ for supporting both of > host and device functional drivers.... USB is "messy" in that we have hardware that acts both as a host and a gadget controller. Don't use our directory scheme as an example to do anything :) Do what is right for the PCI subsystem, if a driver is too "complex" that it needs lots of different files, make a subdirectory to make it easier to manage. That's all we did for USB, nothing really complex. good luck! greg k-h -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html