On Thu, Mar 22, 2018 at 01:43:49AM +0100, Andrew Lunn wrote: > On Wed, Mar 21, 2018 at 03:47:02PM -0700, Richard Cochran wrote: > > I happy to improve the modeling, but the solution should be generic > > and work for every MAC driver. Let me qualify that a bit... > Something else to think about. There are a number of MAC drivers which > don't use phylib. All the intel drivers for example. They have their > own MDIO and PHY code. And recently there have been a number of MAC > drivers for hardware capable of > 1GBps which do all the PHY control > in firmware. > > A phydev is optional, the MAC is mandatory. So MACs that have a built in PHY won't work, but we don't care because there is no way to hang another MII device in there anyhow. We already require phylib for NETWORK_PHY_TIMESTAMPING, and so we expect that here, too. Many of these IP core things will be targeting arm with device tree, and I want that to "just work" without MAC changes. (This is exactly the same situation with DSA, BTW.) If someone attaches an MII time stamper to a MACs whose driver does their own thing without phylib, then they are going to have to hack the MAC driver in any case. Such hacks will never be acceptable for mainline because they are design specific. We really don't have to worry about this case. Thanks, Richard -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html