Hi Rob,
On Sun, Mar 18, 2018 at 07:53:04AM -0500, Rob Herring wrote:
> On Fri, Mar 09, 2018 at 10:43:40AM +0530, Manivannan Sadhasivam wrote:
> > Add gpio nodes for Actions Semi S900 SoC.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> > ---
> > .../devicetree/bindings/gpio/actions,owl-gpio.txt | 90 ++++++++++++++++++++++
> > 1 file changed, 90 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt
> >
> > diff --git a/Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt b/Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt
> > new file mode 100644
> > index 000000000000..ad7d32ce2abe
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt
> > @@ -0,0 +1,90 @@
> > +* Actions Semi OWL GPIO controller bindings
> > +
> > +The GPIOs are organized as individual banks/ports with variable number
> > +of GPIOs. Each bank is represented as an individual GPIO controller.
> > +
> > +Required properties:
> > +- compatible : Should be "actions,s900-gpio"
> > +- reg : Address and range of the GPIO controller registers.
> > +- gpio-controller : Marks the device node as a GPIO controller.
> > +- #gpio-cells : Should be <2>. The first cell is the gpio number
> > + and the second cell is used to specify optional
> > + parameters.
> > +- ngpios : Specifies the number of GPIO lines.
> > +- interrupt-controller : Marks the device node as an interrupt controller.
> > +- #interrupt-cells : Specifies the number of cells needed to encode an
> > + interrupt. Shall be set to 2. The first cell
> > + defines the interrupt number, the second encodes
> > + the trigger flags described in
> > + bindings/interrupt-controller/interrupts.txt
> > +
> > +Optional properties:
> > +- gpio-ranges : Mapping between GPIO and pinctrl
> > +
> > +Examples:
> > +
> > + gpioa: gpio@e01b0000 {
> > + compatible = "actions,s900-gpio";
> > + reg = <0x0 0xe01b0000 0x0 0x1000>;
> > + gpio-controller;
> > + #gpio-cells = <2>;
> > + gpio-ranges = <&pinctrl 0 0 32>;
> > + ngpios = <32>;
>
> This is only needed if the number of gpios is reduced for some reason
> such as not pinned out. IOW, 32 is implied because that's the size of
> each bank.
>
Okay. Then I can remove ngpio property for banks which has 32 GPIOs.
> > + interrupt-controller;
> > + #interrupt-cells = <2>;
> > + };
> > +
> > + gpiob: gpio@e01b000c {
> > + compatible = "actions,s900-gpio";
> > + reg = <0x0 0xe01b000c 0x0 0x1000>;
>
> Due to the sizes, these are still overlapping.
>
Oops, will fix the size.
Thanks,
Mani
> Rob
>
> > + gpio-controller;
> > + #gpio-cells = <2>;
> > + gpio-ranges = <&pinctrl 0 32 32>;
> > + ngpios = <32>;
> > + interrupt-controller;
> > + #interrupt-cells = <2>;
> > + };
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
