Quoting Ryder Lee (2018-03-06 01:09:28) > + > +static const struct of_device_id of_match_clk_mt2701_aud[] = { > + { .compatible = "mediatek,mt2701-audsys", }, > + {} > +}; > + > +static int clk_mt2701_aud_probe(struct platform_device *pdev) > +{ > + struct clk_onecell_data *clk_data; > + struct device_node *node = pdev->dev.of_node; > + int r; > + > + clk_data = mtk_alloc_clk_data(CLK_AUD_NR); > + > + mtk_clk_register_gates(node, audio_clks, ARRAY_SIZE(audio_clks), > + clk_data); > + > + r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); > + if (r) { > + dev_err(&pdev->dev, > + "could not register clock provider: %s: %d\n", > + pdev->name, r); > + > + return r; > + } This fails to remove the clk provider when devm_of_platform_populate() returns an error. > + > + return devm_of_platform_populate(&pdev->dev); > +} > + > +static struct platform_driver clk_mt2701_aud_drv = { > + .probe = clk_mt2701_aud_probe, > + .driver = { > + .name = "clk-mt2701-aud", > + .of_match_table = of_match_clk_mt2701_aud, > + }, > +}; > + > +builtin_platform_driver(clk_mt2701_aud_drv); -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html