Hi Jean, [...] > @@ -3168,6 +3260,13 @@ static int arm_smmu_device_probe(struct platform_device *pdev) > if (ret) > return ret; > > + if (smmu->features & (ARM_SMMU_FEAT_STALLS | ARM_SMMU_FEAT_PRI)) { > + smmu->faultq_nb.notifier_call = arm_smmu_flush_queues; > + ret = iommu_fault_queue_register(&smmu->faultq_nb); > + if (ret) > + return ret; I find a case here: CONFIG_IOMMU_FAULT=n, and smmu support feature STALLS or PRI, the device probe will failed here, is this what we want? Thanks Yisheng > + } > + > /* And we're up. Go go go! */ > ret = iommu_device_sysfs_add(&smmu->iommu, dev, NULL, > "smmu3.%pa", &ioaddr); -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html