Hi, Fabio Anson Huang Best Regards! > -----Original Message----- > From: Fabio Estevam [mailto:festevam@xxxxxxxxx] > Sent: Monday, March 19, 2018 3:54 AM > To: Anson Huang <anson.huang@xxxxxxx> > Cc: Shawn Guo <shawnguo@xxxxxxxxxx>; Sascha Hauer > <kernel@xxxxxxxxxxxxxx>; Fabio Estevam <fabio.estevam@xxxxxxx>; Rob > Herring <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>; > Russell King - ARM Linux <linux@xxxxxxxxxxxxxxx>; dl-linux-imx > <linux-imx@xxxxxxx>; moderated list:ARM/FREESCALE IMX / MXC ARM > ARCHITECTURE <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; open list:OPEN > FIRMWARE AND FLATTENED DEVICE TREE BINDINGS > <devicetree@xxxxxxxxxxxxxxx>; linux-kernel <linux-kernel@xxxxxxxxxxxxxxx> > Subject: Re: [PATCH] ARM: dts: imx7s: add anatop vdd1p2 regulator > > Hi Anson, > > On Sat, Mar 17, 2018 at 4:36 AM, Anson Huang <Anson.Huang@xxxxxxx> > wrote: > > Add i.MX7S/D anatop vdd1p2 regulator. > > > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx> > > --- > > arch/arm/boot/dts/imx7s.dtsi | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/arm/boot/dts/imx7s.dtsi > > b/arch/arm/boot/dts/imx7s.dtsi index cd6964f..1210028 100644 > > --- a/arch/arm/boot/dts/imx7s.dtsi > > +++ b/arch/arm/boot/dts/imx7s.dtsi > > @@ -565,6 +565,21 @@ > > anatop-max-voltage = > <1200000>; > > anatop-enable-bit = <0>; > > }; > > + > > + reg_1p2: > regulator-vdd1p2@30360220 { > > + reg = <0x30360220>; > > + compatible = > "fsl,anatop-regulator"; > > + regulator-name = "vdd1p2"; > > + regulator-min-microvolt = > <1100000>; > > + regulator-max-microvolt = > <1300000>; > > + anatop-reg-offset = > <0x220>; > > + anatop-vol-bit-shift = <8>; > > + anatop-vol-bit-width = <5>; > > + anatop-min-bit-val = > <0x14>; > > + anatop-min-voltage = > <1100000>; > > + anatop-max-voltage = > <1300000>; > > + anatop-enable-bit = <0>; > > + }; > > Do you also plan to add a consumer for it? This regulator is mainly for USB HSIC, the consumer will be added when HSIC do upstream. Anson. ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f