On Sun, Feb 16, 2014 at 10:40:55AM +0100, Wolfram Sang wrote: > From: Wolfram Sang <wsa@xxxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Wolfram Sang <wsa@xxxxxxxxxxxxxxxxxxxx> From your other mail: "[2/5] needs to be reworked to exclude the r8a7790 compatible string." > + compatible = "renesas,i2c-r8a7791", "renesas,i2c-r8a7790"; Why is that? From my knowledge, you start with the exact compatible property and hardware compatible entries may follow. This is backed up by Documentation/devicetree/usage-model.txt: === The 'compatible' property contains a sorted list of strings starting with the exact name of the machine, followed by an optional list of boards it is compatible with sorted from most compatible to least. === And from the devicetree wiki [1]: === compatible is a list of strings. The first string in the list specifies the exact device that the node represents in the form "<manufacturer>,<model>". The following strings represent other devices that the device is compatible with. For example, the Freescale MPC8349 System on Chip (SoC) has a serial device which implements the National Semiconductor ns16550 register interface. The compatible property for the MPC8349 serial device should therefore be: compatible = "fsl,mpc8349-uart", "ns16550". In this case, fsl,mpc8349-uart specifies the exact device, and ns16550 states that it is register-level compatible with a National Semiconductor 16550 UART. Note: ns16550 doesn't have a manufacturer prefix purely for historical reasons. All new compatible values should use the manufacturer prefix. This practice allows existing device drivers to be bound to a newer device, while still uniquely identifying the exact hardware. === Has this changed? [1 ]http://www.devicetree.org/Device_Tree_Usage#Understanding_the_compatible_Property
Attachment:
signature.asc
Description: Digital signature
