> -----Original Message----- > From: Lucas Stach [mailto:l.stach@xxxxxxxxxxxxxx] > Sent: Friday, March 16, 2018 6:10 PM > To: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > Cc: Michael Turquette <mturquette@xxxxxxxxxxxx>; Stephen Boyd > <sboyd@xxxxxxxxxxxxxx>; A.s. Dong <aisheng.dong@xxxxxxx>; > devicetree@xxxxxxxxxxxxxxx; patchwork-lst@xxxxxxxxxxxxxx; Rob Herring > <robh+dt@xxxxxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>; > kernel@xxxxxxxxxxxxxx; Fabio Estevam <fabio.estevam@xxxxxxx>; Shawn > Guo <shawnguo@xxxxxxxxxx>; linux-clk@xxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 4/4] clk: imx: add clock driver for i.MX8MQ CCM > > Am Donnerstag, den 15.03.2018, 22:33 +0100 schrieb Sascha Hauer: > > On Thu, Feb 01, 2018 at 06:54:12PM +0100, Lucas Stach wrote: > > > Add driver for the Clock Control Module found on i.MX8MQ. > > > > > > This is largely based on the downstream driver from Anson Huang and > > > Bai Ping at NXP, with only some small adaptions to mainline from me. > > > > > > Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > > > > A general thought: The i.MX8M finally has a consistent clock tree. We > > have for example 70 Peripheral clock slices consisting of a mux, a > > gate and two dividers, all 70 looking the same. > > For these it might make sense to create a more complex clock type > > providing mux, gate and set rate functionality in one clock. This > > would drastically reduce the number of clocks we have to handle. > > I agree. It seems we are missing the 4.17 merge window with this anyways, > due to the large number of changes still required and time constraints on my > side, so a larger rework of the driver might be possible if we target 4.18. > Yes, that would be worth a try. Thanks for doing it. Regards Dong Aisheng > Regards, > Lucas ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f