On Thu, Mar 01, 2018 at 06:19:31PM -0600, richard.gong@xxxxxxxxxxxxxxx wrote: > +EXPORT_SYMBOL_GPL(request_svc_channel_byname); All of your global symbols should have the same prefix, not a verb. So this should be: svc_channel_request_by_name(), right? > +EXPORT_SYMBOL_GPL(free_svc_channel); svc_channel_free()? > +EXPORT_SYMBOL_GPL(intel_svc_send); Wait, why doesn't the first ones have "intel_svc" in them? What is the difference here? Should they all just have "intel_svc_" as the prefix? Stick to one thing for all exported functions/variables please, it's the only way we can attempt to keep our namespace "sane". Also, why would a 'misc' driver be exporting things that something else uses? Why not just put this in the fpga directory next to the users of this code? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
