On Thursday 15 March 2018 02:22 PM, Adrian Hunter wrote: > On 15/03/18 10:47, Ulf Hansson wrote: >> On 7 March 2018 at 14:20, Kishon Vijay Abraham I <kishon@xxxxxx> wrote: >>> Add UHS/HS200 mode support in sdhci-omap. The programming sequence >>> for voltage switching, tuning is followed from AM572x TRM >>> http://www.ti.com/lit/ug/spruhz6i/spruhz6i.pdf >>> (Similar to all AM57x/DRA7x SoCs). The patch series also implements >>> workaround for errata published in >>> http://www.ti.com/lit/er/sprz429k/sprz429k.pdf >>> >>> patches are created on top of >>> git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next >>> >>> Patches in v2 already applied to mmc -next are dropped from the >>> series. >>> >>> Changes from v2: >>> *) Changed SW timeout logic as per Adrians's suggestion >>> *) Validated SDIO with the current patches (added a couple of fixes >>> found while adding SDIO support). >>> *) Used soc_device_match() instead of pdata-quirks as per Tony's >>> suggestions. >>> >>> Changes from v1: >>> *) Only poll on DAT0 and DATI for card_busy status >>> *) Cleanup iodelay patch as suggested by Tony. >>> *) Added quirk to disable HW timeout >>> *) Use the existing data timer but program a relatively accurate >>> SW timeout value (Impacts all platforms) >>> *) Fix a bug in sdhci which was using data_timer for non data line >>> commands >>> >>> Kishon Vijay Abraham I (11): >>> mmc: sdhci-omap: Fix when capabilities are obtained from >>> SDHCI_CAPABILITIES reg >>> mmc: sdhci-omap: Remove setting ADMA capability in driver >>> mmc: sdhci-omap: Workaround for Errata i843 >>> mmc: sdhci-omap: Invoke sdhci_get_of_property to read sdhci dt >>> properties >>> mmc: sdhci: Disable HS200 mode if controller can't support 1.8v >>> mmc: sdhci: Add quirk to disable HW timeout >>> mmc: sdhci: Program a relatively accurate SW timeout value >>> mmc: sdhci-omap: Workaround for Errata i834 >>> dt-bindings: sdhci-omap: Add K2G specific binding >>> mmc: sdhci-omap: Add support for MMC/SD controller in k2g SoC >>> mmc: sdhci-omap: Add sdhci_omap specific ops for enable_sdio_irq >>> >>> .../devicetree/bindings/mmc/sdhci-omap.txt | 2 + >>> drivers/mmc/host/sdhci-omap.c | 78 +++++++++++++++++++--- >>> drivers/mmc/host/sdhci.c | 75 +++++++++++++++++---- >>> drivers/mmc/host/sdhci.h | 15 +++++ >>> 4 files changed, 148 insertions(+), 22 deletions(-) >>> >>> -- >>> 2.11.0 >>> >> >> Overall this looks good to me, however it seems like we need to give >> Adrian a little more time to comment. >> > > I will try to look at it today. sure, thanks! -Kishon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
