Re: [PATCH v2 7/7] ASoC: samsung: Add HDMI audio support for Chromebook Snow

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 12, 2018 at 05:21:03PM +0100, Sylwester Nawrocki wrote:
> On 03/12/2018 08:39 AM, Krzysztof Kozlowski wrote:
> >> -#define FIN_PLL_RATE           24000000
> >> +#define FIN_PLL_RATE           24000000UL
> >
> > This change looks unrelated so how about making it separate patch?
> 
> I knew you will find this! ;P I don't want to be making this kind
> of funny patches :), I can repost v3 in a few days with this bit removed.

Ah, you know, after working with crappy code and crappy history, I find
very useful to have strict approach around changes.  This one might be
harmless... or you might be fixing some warning caught by your
compiler thus it looks like nice candidate for seaprate patch.

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux