Hi, On Wed, Feb 21, 2018 at 10:12 PM, Rajendra Nayak <rnayak@xxxxxxxxxxxxxx> wrote: > + gcc: clock-controller@100000 { > + compatible = "qcom,gcc-sdm845"; > + reg = <0x100000 0x1f0000>; > + #clock-cells = <1>; > + #reset-cells = <1>; > + }; Seems like we need "#power-domain-cells = <1>;" in the gcc node. It is true that the property is listed as "optional" in the bindings, but we certainly know that the "include/dt-bindings/clock/qcom,gcc-sdm845.h" that's posted [1] contains several defines ending in "_GDSC" and once we start referencing those we'll need "#power-domain-cells". Seems like we should just have it from the beginning. NOTE: IMHO adding "#power-domain-cells" could be done as a follow-on patch, but since (I think) this series still hasn't landed I guess we could just send up v6? [1] https://patchwork.kernel.org/patch/10267093/ -Doug -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html