On 07/03/18 18:57, Eric Anholt wrote: > The VCHIQ communication channel can be provided by BCM283x and Capri > SoCs, to communicate with the VPU-side OS services. > > Signed-off-by: Eric Anholt <eric@xxxxxxxxxx> > --- > > v2: dropped firmware property, added cache-line-size. > > .../bindings/soc/bcm/brcm,bcm2835-vchiq.txt | 28 ++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt > > diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt > new file mode 100644 > index 000000000000..cdef4abc5e47 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt > @@ -0,0 +1,28 @@ > +Broadcom VCHIQ firmware services > + > +Required properties: > + > +- compatible: Should be "brcm,bcm2835-vchiq" > +- reg: Physical base address and length of the doorbell register pair > +- interrupts: The interrupt number > + See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt > + > +Optional properties: > + > +- cache-line-size: > + Size of L2 cache lines. The VPU firmware detects Which L2 cache is this ? VPU or CPUs ? If CPUs, just drop it and get it from CPU nodes if you need it. If VPUs, it's better add that to the name as CPUs use "cache-line-size" At-least for me, it looked like you are specifying CPU L2 cache line size and hence thought to comment. -- Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
