On 7.3.2018 20:50, Anton Gerasimov wrote:
> Hi Michal,
>
> thank you for the detailed review. I'm fixing most of the issues, I've
> just got one note and one question.
>
>> Do you really wants to have 3 leds doing heartbeat?
>
> Actually it is one RGB package. But it's controlled through programmable
> logic, so I'll just remove it, my bad.
>
>>> + };
>>> +
>>> + usr_led1 {
>>> + label = "usr_led1";
>>> + gpios = <&gpio0 0x0 0x1>;
>>> + default-state = "off";
>>> + linux,default-trigger = "none";
>> This is not the part of binding and I think it is useless anyway.
>>
>>> + };
>>> +
>>> + usr_led2 {
>>> + label = "usr_led2";
>>> + gpios = <&gpio0 0x9 0x1>;
>>> + default-state = "off";
>>> + linux,default-trigger = "none";
>> ditto
>
> These two are on the contrary real LEDs that are controlled by hardware
> GPIO. You mean they don't belong here because user can control them with
> GPIO interface?
I really meant that linux,default-trigger = "none" shouldn't be there.
user led description is fine.
Also I just spot that you should use dashes instead of underscores in
node name. It means usr-led2 here.
Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
