On Thu, Mar 01, 2018 at 06:19:32PM -0600, richard.gong@xxxxxxxxxxxxxxx wrote: > From: Alan Tull <atull@xxxxxxxxxx> > > Add a Device Tree binding for the Intel Stratix10 SoC FPGA manager. > > Signed-off-by: Alan Tull <atull@xxxxxxxxxx> > --- > v2: this patch is added in patch set version 2 > --- > .../devicetree/bindings/fpga/intel-stratix10-soc-fpga-mgr.txt | 10 ++++++++++ > 1 file changed, 10 insertions(+) > create mode 100644 Documentation/devicetree/bindings/fpga/intel-stratix10-soc-fpga-mgr.txt > > diff --git a/Documentation/devicetree/bindings/fpga/intel-stratix10-soc-fpga-mgr.txt b/Documentation/devicetree/bindings/fpga/intel-stratix10-soc-fpga-mgr.txt > new file mode 100644 > index 0000000..78de689 > --- /dev/null > +++ b/Documentation/devicetree/bindings/fpga/intel-stratix10-soc-fpga-mgr.txt > @@ -0,0 +1,10 @@ > +Intel Stratix10 SoC FPGA Manager > + > +Required properties: > +- compatible : should contain "intel,stratix10-soc-fpga-mgr" > + > +Example: > + > + fpga_mgr: fpga-mgr@0 { > + compatible = "intel,stratix10-soc-fpga-mgr"; No reg or anything else? Is that because it all goes thru the service layer firmware? Just get the service layer driver to instantiate a device for this driver or get rid of the 2 layers if that's all the firmware interface does. DT is not a Linux driver instantiation mechanism. And build your dts files with "W=1" because there's an error in this example. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html