Hello Mark, Thanks for the review. On Mon, 5 Mar 2018 15:59:38 +0000 Mark Brown <broonie@xxxxxxxxxx> wrote: > On Mon, Mar 05, 2018 at 04:57:15PM +0100, Alexandre Belloni wrote: > > On 05/03/2018 at 15:49:10 +0000, Mark Brown wrote: > > > > Please don't mix C and C++ style comments in a single comment like this > > > - it looks unintentional. Just use the same style for the whole thing. > > > You also don't need to include all the boilerplate with the SPDX header. > > > I think Linus made it clear that he wants the SPDX header to be a > > C++ comment, the documentation has: > > Sure, so make the entire thing a C++ comment then. Ok, I saw other drivers with this mix C++/C comment code so I wrote it like this but no problem using only C++ comment. I will send a v3 with this modification only (except if I have other reviews). Best regards, -- Mylène Josserand, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
