On 5 March 2018 at 15:36, <musashino.open@xxxxxxxxx> wrote: > From: INAGAKI Hiroshi <musashino.open@xxxxxxxxx> > > Buffalo WZR-900DHP has 8 LEDs, but there is not LED definitions in the > dts and cannot configure these LEDs. > I Added missing LED definitions for WZR-900DHP. > > Signed-off-by: INAGAKI Hiroshi <musashino.open@xxxxxxxxx> Looks almost good, thanks for sending this patch to Florian. One comment: please drop all linux,default-trigger = "default-off"; lines. I did the same mistake long time ago, see my fixing commit: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0b660259e927177dc0c6eb3b1c39f23c6a011c5f When you fix that, please generate a V2 of your patch, you can do it with something like: git format-patch --subject-prefix="PATCH V2" -1 and send again the same way. Thanks! -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html