On Mon 26 Feb 09:58 PST 2018, Lina Iyer wrote:
> From: Mahesh Sivasubramanian <msivasub@xxxxxxxxxxxxxx>
>
> Command DB provides information on shared resources like clocks,
> regulators etc., probed at boot by the remote subsytem and made
> available in shared memory.
>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Signed-off-by: Mahesh Sivasubramanian <msivasub@xxxxxxxxxxxxxx>
> Signed-off-by: Lina Iyer <ilina@xxxxxxxxxxxxxx>
> ---
>
> Changes in v4:
> - Fix unwanted capitalization
> - Add reg property
> ---
> .../devicetree/bindings/arm/msm/cmd-db.txt | 38 ++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/msm/cmd-db.txt
>
> diff --git a/Documentation/devicetree/bindings/arm/msm/cmd-db.txt b/Documentation/devicetree/bindings/arm/msm/cmd-db.txt
[..]
> + reserved-memory {
> + [...]
> + qcom,cmd-db@c3f000c {
> + reg = <0x0 0xc3f000c 0x0 0x8>,
> + <0x0 0x85fe0000 0x0 0x20000>;
I'm still concerned about the use of the redirection mapping here,
the relocation at 0xc3f000c is used a convenience thing so that the
command db can be relocated, but because of how Linux will consume any
non-reserved memory the dts would still need to be manually updated.
As such I think you should just describe only the 0x85fe0000 + 0x20000
region here and to support the dynamic aspect of this from a system
point of view you can have the boot loader read the information at
0xc3f000c and adjust the reserved memory. (Or just keep the step of
manually update the dts without caring about the indirection)
Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
