On Fri, Feb 14, 2014 at 01:20:58PM +0000, Marek Belisko wrote: > Signed-off-by: Marek Belisko <marek@xxxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/hwmon/twl4030-madc-hwmon.txt | 9 +++++++++ > drivers/hwmon/twl4030-madc-hwmon.c | 10 ++++++++++ > 2 files changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/twl4030-madc-hwmon.txt > > diff --git a/Documentation/devicetree/bindings/hwmon/twl4030-madc-hwmon.txt b/Documentation/devicetree/bindings/hwmon/twl4030-madc-hwmon.txt > new file mode 100644 > index 0000000..e8016d1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/twl4030-madc-hwmon.txt > @@ -0,0 +1,9 @@ > +TWL4030 MADC hwmon. > + > +Required properties: > +- compatible: "ti,twl4030-madc-hwmon" > + > +Example: > +madc-hwmon { > + compatible = "ti,twl4030-madc-hwmon"; > +}; Huh? What is this a binding for? From a look at the driver in mainline this just calls into functions from the twl4030 madc driver (which doesn't seem to have a binding). This doesn't look like a description of hardware, but rather a hack to get a Linux driver to probe. As far as I can see, no useful information is given by this binding. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html