On Thu, Feb 22, 2018 at 4:13 PM, Amelie DELAUNAY <amelie.delaunay@xxxxxx> wrote: > ST MFX is different from STMPE as far as the HW is completely different. > IDD is a new feature. > TS management is completely different. > GPIO management looks like but is also rather different. > ST MFX counts a first level of 8 interrupts (acked by writing in the ACK > register), then a second level of 24 interrupts for GPIOs. GPIO IRQ can > be triggered on low level, falling edge, high level, rising edge. GPIO > IRQ have to be acked by writing in the GPI_ACK register, GPIO can be > output open-drain with/without internal pull-up, output push-pull, input > with pull-up/down, input floating or analog. Okay I am convinced that we need to model this as its own driver if it is as different as you say. But let's keep an eye on STMPE's approaches and what it does right and wrong. If I rewrote the STMPE driver today, the major changes would be to use regmap to pass around to subdrivers, and implement a combined pin control and GPIO driver, so I think those things should be nice to have for the next iteration. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
