Re: [PATCH net-next v4 00/10] Support for the Broadcom GENET driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




2014-02-13 15:39 GMT-08:00 David Miller <davem@xxxxxxxxxxxxx>:
> From: David Miller <davem@xxxxxxxxxxxxx>
> Date: Thu, 13 Feb 2014 18:38:06 -0500 (EST)
>
>> From: Florian Fainelli <f.fainelli@xxxxxxxxx>
>> Date: Thu, 13 Feb 2014 15:30:12 -0800
>>
>>> This patchset adds support for the Broadcom GENET Gigabit Ethernet MAC
>>> controller. This controller is found on the Broadcom BCM7xxx Set Top Box
>>> System-on-a-chips.
>>>
>>> Changes since v3:
>>> - fixed Kconfig dependency on FIXED_PHY
>>>
>>> Changes since v2:
>>> - dropped the patch that adds an "internal" phy-mode
>>
>> Looks better, series applied, thanks.
>
> Actually, I have to revert, this breaks the allmodconfig build on x86_64:
>
> drivers/net/ethernet/broadcom/genet/bcmmii.c: In function ‘bcmgenet_mii_of_init’:
> drivers/net/ethernet/broadcom/genet/bcmmii.c:404:2: error: implicit declaration of function ‘of_get_next_child’ [-Werror=implicit-function-declaration]
> drivers/net/ethernet/broadcom/genet/bcmmii.c:404:10: warning: assignment makes pointer from integer without a cast [enabled by default]
> cc1: some warnings being treated as errors

Ok, would you agree in having a big fat "depends on OF" for now until
I can get an empty stub going with the DT people?
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux