On Wed, Feb 28, 2018 at 11:56:27AM +0100, Geert Uytterhoeven wrote:
> On Mon, Feb 26, 2018 at 9:54 PM, Sergei Shtylyov
> <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote:
> > Define the generic R8A77970 parts of the I2C[0-4] device node.
> >
> > Based on the original (and large) patch by Daisuke Matsushita
> > <daisuke.matsushita.ns@xxxxxxxxxxx>.
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
> >
> > ---
> > Changes in version 2:
> > - made use of the SYSC power domain #define's;
> > - moved the I2C nodes before HSCIF nodes.
>
> auto-repeat below...
>
> > arch/arm64/boot/dts/renesas/r8a77970.dtsi | 88 ++++++++++++++++++++++++++++++
> > 1 file changed, 88 insertions(+)
> >
> > Index: renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> > ===================================================================
> > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> > +++ renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> > @@ -19,6 +19,14 @@
> > #address-cells = <2>;
> > #size-cells = <2>;
> >
> > + aliases {
> > + i2c0 = &i2c0;
> > + i2c1 = &i2c1;
> > + i2c2 = &i2c2;
> > + i2c3 = &i2c3;
> > + i2c4 = &i2c4;
> > + };
> > +
> > psci {
> > compatible = "arm,psci-1.0", "arm,psci-0.2";
> > method = "smc";
> > @@ -338,6 +346,86 @@
> > <&ipmmu_ds1 22>, <&ipmmu_ds1 23>;
> > };
> >
> > + i2c0: i2c@e6500000 {
> > + compatible = "renesas,i2c-r8a77970",
> > + "renesas,rcar-gen3-i2c";
> > + reg = <0 0xe6500000 0 0x40>;
> > + interrupts = <GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 931>;
> > + power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
> > + resets = <&cpg 931>;
> > + dmas = <&dmac1 0x91>, <&dmac1 0x90>;
>
> Can't all five i2c interfaces be used with both dmac1 and dmac2?
>
> With that fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Sergei, please address this review and repost as appropriate.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
