RE: [PATCH] arm64: dts: ls1046a: drop incomplete memory node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@xxxxxxxxxx]
> Sent: Saturday, February 24, 2018 3:05 PM
> To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx; Shawn Guo <shawnguo@xxxxxxxxxx>;
> Mingkai Hu <mingkai.hu@xxxxxxx>; Shaohui Xie <Shaohui.Xie@xxxxxxx>;
> Leo Li <leoyang.li@xxxxxxx>
> Subject: [PATCH] arm64: dts: ls1046a: drop incomplete memory node
> 
> The memory node in fsl-ls1046a.dtsi has no 'reg' property, and causes the
> dtc warning below.
> 
> Warning (unit_address_vs_reg): Node /memory@80000000 has a unit name,
> but no reg property
> 
> This is clearly an incomplete memory node.  Let's drop it.  Either a complete
> memory should be added, or bootloader needs to fill the node as a whole.

Or we can put in a dummy reg property to be updated by bootloader like the mac-address property?

> 
> Cc: Mingkai Hu <Mingkai.Hu@xxxxxxx>
> Cc: Shaohui Xie <Shaohui.Xie@xxxxxxx>
> Cc: Li Yang <leoyang.li@xxxxxxx>
> Signed-off-by: Shawn Guo <shawnguo@xxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index 606ea496f24e..cbf4b3e15c17 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -129,10 +129,6 @@
>  		};
>  	};
> 
> -	memory@80000000 {
> -		device_type = "memory";
> -	};
> -
>  	sysclk: sysclk {
>  		compatible = "fixed-clock";
>  		#clock-cells = <0>;
> --
> 1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux