Hi, On Fri, 23 Feb 2018 15:56:50 +0100 Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > On Fri, Feb 23, 2018 at 02:37:34PM +0100, Mylène Josserand wrote: > > To prepare the support for sun8i-a83t, rename the variable name > > that handles the power-off of clusters because it is different from > > sun9i-a80 to sun8i-a83t. > > > > The power off register for clusters are different from SUN9I and SUN8I > > This is just a nitpick, and I see you use them everywhere, but sun8i > and sun9i are the family of SoCs, and A80 and A83t the name of SoCs > within their respective families. > > So in your commit log, you want to support the A83t because it's > different than the A80, and the sun9i and sun8i mentionned in your > last sentence is not really meaningful. True, I will pay attention next time. > > > Signed-off-by: Mylène Josserand <mylene.josserand@xxxxxxxxxxx> > > Acked-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxx> > > Maxime > Thanks, Mylène -- Mylène Josserand, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
