On 02/22/2018 02:52 PM, Linus Walleij wrote:
> Hi Amelie,
>
> thanks for your patch.
>
> On Thu, Feb 8, 2018 at 3:27 PM, Amelie Delaunay <amelie.delaunay@xxxxxx> wrote:
>
>> The joystick on stm32746g-eval uses gpios on MFX gpio expander.
>>
>> Signed-off-by: Amelie Delaunay <amelie.delaunay@xxxxxx>
> (...)
>> + joystick {
>> + compatible = "gpio-keys";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + button@1 {
>> + label = "JoySel";
>> + linux,code = <KEY_ENTER>;
>> + gpios = <&mfxgpio 0 (GPIO_ACTIVE_LOW | GPIO_IN_PUSH_PULL | GPIO_PULL_UP)>;
>> + };
>
> As I think this should not all be handled by GPIO, the joystick on
> gpio-keys needs a pin control handle pointing back to pin control
> states on the respective pins in the pin control/GPIO driver,
> where it can set up these properties.
>
> For the individual lines the pushing and pulling flags should be
> removed.
>
Sure! I keep this in mind, thanks!
Regards,
Amelie
> Yours,
> Linus Walleij
> ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
