On 22/02/18 09:04, Quentin Perret wrote: > Hi Sudeep, > > On Monday 12 Feb 2018 at 18:45:23 (+0000), Sudeep Holla wrote: > [...] >> +/* >> + * perf_ops->freq_set is not a synchronous, the actual OPP change will >> + * happen asynchronously and can get notified if the events are >> + * subscribed for by the SCMI firmware >> + */ >> +static int >> +scmi_cpufreq_set_target(struct cpufreq_policy *policy, unsigned int index) >> +{ >> + struct scmi_data *priv = policy->driver_data; >> + struct scmi_perf_ops *perf_ops = handle->perf_ops; >> + u64 freq = policy->freq_table[index].frequency * 1000; >> + >> + return perf_ops->freq_set(handle, priv->domain_id, freq, false); >> +} > > Is arch_set_freq_scale() needed in this function ? > Yes indeed, already added locally[1] after Dietmar started the discussion. -- Regards, Sudeep [1] https://git.kernel.org/sudeep.holla/linux/h/for-list/new_arm_scmi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html