> > The MiPHY365x is a Generic PHY which can serve various SATA or PCIe > > devices. It has 2 ports which it can use for either; both SATA, both > > PCIe or one of each in any configuration. > > > > Cc: devicetree@xxxxxxxxxxxxxxx > > Cc: Srinivas Kandagatla <srinivas.kandagatla@xxxxxx> > > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx> > > --- > > .../devicetree/bindings/phy/phy-miphy365x.txt | 43 ++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/phy/phy-miphy365x.txt > > > > diff --git a/Documentation/devicetree/bindings/phy/phy-miphy365x.txt b/Documentation/devicetree/bindings/phy/phy-miphy365x.txt > > new file mode 100644 > > index 0000000..fdfa7ca > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/phy-miphy365x.txt > > @@ -0,0 +1,43 @@ > > +STMicroelectronics STi MIPHY365x PHY binding > > +============================================ > > + > > +This binding describes a miphy device that is used to control PHY hardware > > +for SATA and PCIe. > > + > > +Required properties: > > +- compatible: Should be "st,miphy365x-phy" > > +- #phy-cells: Should be 2 (See example) > > The first example has #phy-cells = <1>. Right, will fix. Should be 2. > What do the cells mean? What are the expected values? http://www.spinics.net/lists/arm-kernel/msg307209.html > > +- reg: Address and length of the register set for the device > > +- reg-names: The names of the register addresses corresponding to the > > + registers filled in "reg". > > Whenever there is a ${PROP}-names property, there should be a list of > explicit values, and a description of how it relates to ${PROP}. Without > that it's a bit useless. > > Please provide an explicit list of expected names here. > > I assume here what you want is something like: > > - reg: a list of address + length pairs, one for each entry in reg-names > - reg-names: should contain: > * "sata0" for the sata0 control registers... > * "sata1" ... > * "pcie0" ... > * "pcie1" ... Can do. > > +- st,syscfg : Should be a phandle of the syscfg node. > > What's this used for? It's used to gain access to the system configuration registers. Specifically in this case the bits to choose between PCI or SATA mode. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
