Hi Philippe, On Tue, Feb 20, 2018 at 08:53:22AM +0100, Philippe Ombredanne wrote: > Dear Manivannan, > > On Sat, Feb 17, 2018 at 9:44 PM, Manivannan Sadhasivam > <manivannan.sadhasivam@xxxxxxxxxx> wrote: > > Add pinctrl driver for Actions Semi S900 SoC. The driver supports > > pinctrl, pinmux and pinconf functionalities through a range of registers > > common to both gpio driver and pinctrl driver. > > > > Pinmux functionality is available only for the pin groups while the > > pinconf functionality is available for both pin groups and individual > > pins. > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > > <snip> > > > > --- /dev/null > > +++ b/drivers/pinctrl/actions/pinctrl-s900.c > > @@ -0,0 +1,2536 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > <snip> > > > +MODULE_LICENSE("GPL v2"); > > This does not match your license above. Per module.h "GPL v2" means > GPL-2.0 where you license above GPL-2.0+ means or later > Should be MODULE_LICENSE("GPL"). Will get it fixed in next revision. Thanks, Mani > -- > Cordially > Philippe Ombredanne -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html