Hello Mark, Thank you for your review. > -----Original Message----- > From: Mark Brown [mailto:broonie@xxxxxxxxxx] > Sent: Wednesday, February 21, 2018 9:14 PM > To: Suzuki, Katsuhiro <suzuki.katsuhiro@xxxxxxxxxxxxx> > Cc: alsa-devel@xxxxxxxxxxxxxxxx; Rob Herring <robh+dt@xxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; Masami Hiramatsu > <masami.hiramatsu@xxxxxxxxxx>; Jassi Brar <jaswinder.singh@xxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/2] ASoC: add DT bindings documentation for ROHM BD28623 codec > > On Wed, Feb 21, 2018 at 01:33:10PM +0900, Katsuhiro Suzuki wrote: > > > +Optional properties: > > +- VCCA-supply : regulator phandle for the VCCA supply > > +- VCCP1-supply: regulator phandle for the VCCP1 supply > > +- VCCP2-supply: regulator phandle for the VCCP2 supply > > These should be documented as mandatory unless the device genuinely > operates without power which seems unlikely. Indeed, this IC does not work correctly if VCC power supply is lost. It's not optional. I'll fix it and send V2. Regards, -- Katsuhiro Suzuki -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
