Hi Charles, Thank you for the patch! Yet something to improve: [auto build test ERROR on ljones-mfd/for-mfd-next] [also build test ERROR on v4.16-rc2 next-20180220] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Charles-Keepax/mfd-arizona-Update-reset-pin-to-use-GPIOD/20180221-052657 base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next config: x86_64-randconfig-h0-02210830 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/mfd/arizona-core.c: In function 'arizona_enable_reset': >> drivers/mfd/arizona-core.c:282:3: error: implicit declaration of function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration] gpiod_set_value_cansleep(arizona->pdata.reset, 0); ^~~~~~~~~~~~~~~~~~~~~~~~ gpio_set_value_cansleep drivers/mfd/arizona-core.c: In function 'arizona_of_get_core_pdata': >> drivers/mfd/arizona-core.c:802:17: error: implicit declaration of function 'devm_gpiod_get_from_of_node'; did you mean 'devm_gpio_request_one'? [-Werror=implicit-function-declaration] pdata->reset = devm_gpiod_get_from_of_node(arizona->dev, ^~~~~~~~~~~~~~~~~~~~~~~~~~~ devm_gpio_request_one >> drivers/mfd/arizona-core.c:805:10: error: 'GPIOD_OUT_LOW' undeclared (first use in this function); did you mean 'GPIOF_INIT_LOW'? GPIOD_OUT_LOW, ^~~~~~~~~~~~~ GPIOF_INIT_LOW drivers/mfd/arizona-core.c:805:10: note: each undeclared identifier is reported only once for each function it appears in drivers/mfd/arizona-core.c: In function 'arizona_dev_init': >> drivers/mfd/arizona-core.c:1067:26: error: implicit declaration of function 'devm_gpiod_get'; did you mean 'devm_gpio_free'? [-Werror=implicit-function-declaration] arizona->pdata.reset = devm_gpiod_get(arizona->dev, "reset", ^~~~~~~~~~~~~~ devm_gpio_free drivers/mfd/arizona-core.c:1068:13: error: 'GPIOD_OUT_LOW' undeclared (first use in this function); did you mean 'GPIOF_INIT_LOW'? GPIOD_OUT_LOW); ^~~~~~~~~~~~~ GPIOF_INIT_LOW cc1: some warnings being treated as errors vim +282 drivers/mfd/arizona-core.c 278 279 static inline void arizona_enable_reset(struct arizona *arizona) 280 { 281 if (arizona->pdata.reset) > 282 gpiod_set_value_cansleep(arizona->pdata.reset, 0); 283 } 284 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip