On 02/12/2014 08:56 PM, Rob Herring wrote: > On Wed, Feb 12, 2014 at 12:43 PM, delicious quinoa > <delicious.quinoa@xxxxxxxxx> wrote: >> On Wed, Feb 12, 2014 at 12:32 PM, Rob Herring <robherring2@xxxxxxxxx> wrote: >>> On Wed, Feb 12, 2014 at 11:34 AM, delicious quinoa >>> <delicious.quinoa@xxxxxxxxx> wrote: >>>> From: Alan Tull <atull@xxxxxxxxxx> >>>> >>>> export of_irq_count so it can be used in drivers that are built >>>> as modules. >>> >>> What drivers? Drivers generally should be using resources rather than >>> this function directly. >> >> It's for the DesignWare GPIO driver I've been upstreaming. The >> DesignWare IP can be configured to be one irq for all the gpios or one >> irq per gpio. I want to support both cases. So I need to know how >> many irqs are specified in the device tree. > > Okay. You should merge this as part of that then, so: > > Acked-by: Rob Herring <robh@xxxxxxxxxx> I think we should be consistent and there are other methods how to solve this. I have sent the same patch long time ago. https://lkml.org/lkml/2013/5/30/265 Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
Attachment:
signature.asc
Description: OpenPGP digital signature