Thanks Philippe, I will take this into account for V2. Regards, Amelie On 02/12/2018 03:15 PM, Philippe Ombredanne wrote: > Amelie, > > On Mon, Feb 12, 2018 at 1:06 PM, Lee Jones <lee.jones@xxxxxxxxxx> wrote: >> On Thu, 08 Feb 2018, Amelie Delaunay wrote: >> >>> ST Multi-Function eXpander (MFX) is a slave controller using I2C >>> for communication with the main MCU. Main features are: >>> - 16 fast GPIOs individually configurable in input/output >>> - 8 alternate GPIOs individually configurable in input/output >>> - Main MCU IDD measurement >>> - Resistive touchscreen controller >>> >>> Only GPIO expander (16 fast GPIOs + 8 alternate) feature is >>> supported for the moment. >>> >>> Signed-off-by: Amelie Delaunay <amelie.delaunay@xxxxxx> > > <snip> > >>> --- /dev/null >>> +++ b/drivers/mfd/st-mfx.c >>> @@ -0,0 +1,526 @@ >>> +/* >>> + * STMicroelectronics Multi-Function eXpander (ST-MFX) Core Driver >>> + * >>> + * Copyright (C) 2017, STMicroelectronics - All Rights Reserved >>> + * Author(s): Amelie Delaunay <amelie.delaunay@xxxxxx> for STMicroelectronics. >> >> You don't need to put "for STMicroelectronics". This was something we >> made up when submitting from a different (!st.com) email address. >> >>> + * License terms: GPL V2.0. >>> + * >>> + * st-mfx Core Driver is free software; you can redistribute it and/or modify it >>> + * under the terms of the GNU General Public License version 2 as published by >>> + * the Free Software Foundation. >>> + * >>> + * st-mfx Core Driver is distributed in the hope that it will be useful, but >>> + * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >>> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more >>> + * details. >>> + * >>> + * You should have received a copy of the GNU General Public License along with >>> + * st-mfx Core Driver. If not, see <http://www.gnu.org/licenses/>. >> >> You should be able to use the short version of the licensing >> agreement. Also, please grep for "SPDX". > > You can check the doc for the (fairly new) way to remove legalese > boilerplate at Documentation/process/license-rules.rst or [1] > It helps keep the focus on the code and less on licensing! > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst > ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f