On Vi, 2018-02-16 at 12:14 +0000, Mark Brown wrote: > On Tue, Feb 13, 2018 at 04:29:33PM +0200, Daniel Baluta wrote: > > > > > +++ b/sound/soc/codecs/ak5558.c > > @@ -0,0 +1,417 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > Just make this a C++ commment, don't mix C and C++ - it looks neater. > Otherwise this looks good so I'll apply, please send a followup patch > for the above. Hi Mark, Will send a separate patch to fix this. Anyhow, lets make sure that I got it right because looking into sound/soc/codecs I can see a mixes of styles. So, for ak5558.c the correct code should be: // SPDX-License-Identifier: GPL-2.0 // // Audio driver for AK5558 ADC // // Copyright (C) 2015 Asahi Kasei Microdevices Corporation // Copyright 2018 NXP // Now, for the .h there is a total different story. As per Philippe's link to documentation [1] the .h file should start with: C header: /* SPDX-License-Identifier: <SPDX License Expression> */ So, is the header ak5558.h looking like this, all right? /* SPDX-License-Identifier: GPL-2.0 */ /* * Audio driver header for AK5558 * * Copyright (C) 2016 Asahi Kasei Microdevices Corporation * Copyright 2018 NXP */ Are you willing to take patches fixing the SPDX identifier for the rest of the codecs in sounc/soc/codecs? I've got a bunch of students looking for cleanup patches in their application for Google Summer of Code :). thanks, Daniel. [1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst#n67 ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
