Hi Simon, On Thu, Feb 15, 2018 at 4:31 PM, Simon Horman <horms@xxxxxxxxxxxx> wrote: > On Tue, Feb 13, 2018 at 10:45:49AM +0100, Jacopo Mondi wrote: >> Initial support for R-Car M3-N (r8a77965), including core and module >> clocks. >> >> Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> >> --- >> .../devicetree/bindings/clock/renesas,cpg-mssr.txt | 1 + >> drivers/clk/renesas/Kconfig | 5 + >> drivers/clk/renesas/Makefile | 1 + >> drivers/clk/renesas/r8a77965-cpg-mssr.c | 333 +++++++++++++++++++++ >> drivers/clk/renesas/renesas-cpg-mssr.c | 6 + >> drivers/clk/renesas/renesas-cpg-mssr.h | 1 + >> include/dt-bindings/clock/r8a77965-cpg-mssr.h | 62 ++++ >> 7 files changed, 409 insertions(+) >> create mode 100644 drivers/clk/renesas/r8a77965-cpg-mssr.c >> create mode 100644 include/dt-bindings/clock/r8a77965-cpg-mssr.h >> >> diff --git a/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt >> index f1890d0..246ab63 100644 >> --- a/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt >> +++ b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt >> @@ -22,6 +22,7 @@ Required Properties: >> - "renesas,r8a7794-cpg-mssr" for the r8a7794 SoC (R-Car E2) >> - "renesas,r8a7795-cpg-mssr" for the r8a7795 SoC (R-Car H3) >> - "renesas,r8a7796-cpg-mssr" for the r8a7796 SoC (R-Car M3-W) >> + - "renesas,r8a77965-cpg-mssr" for the r8a77965 SoC (R-Car M3-N) >> - "renesas,r8a77970-cpg-mssr" for the r8a77970 SoC (R-Car V3M) >> - "renesas,r8a77995-cpg-mssr" for the r8a77995 SoC (R-Car D3) >> > > Its up to Geert, but would it be better if the bindings documentation > and driver changes where in separate patches? I don't care that much anymore. It used to be a good idea when the bindings header went in separately, as it was a dependency for both driver and DTS. But now we use hardcoded constants in the first version of the DTS, so it doesn't matter anymore. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html