On Wed, Feb 14, 2018 at 5:28 PM, Mark Brown <broonie@xxxxxxxxxx> wrote: > The patch > > regulator: dt: regulator-name is required property > > has been applied to the regulator tree at > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git > > All being well this means that it will be integrated into the linux-next > tree (usually sometime in the next 24 hours) and sent to Linus during > the next merge window (or sooner if it is a bug fix), however if > problems are discovered then the patch may be dropped or reverted. > > You may get further e-mails resulting from automated or manual testing > and review of the tree, please engage with people reporting problems and > send followup patches addressing any issues that are reported if needed. > > If any updates are required or you are submitting further changes they > should be sent as incremental updates against current git, existing > patches will not be replaced. > > Please add any relevant lists and maintainers to the CCs when replying > to this mail. > > Thanks, > Mark > > From 4b75291621830acad2c66a1d21d7840a7ca169d3 Mon Sep 17 00:00:00 2001 > From: Harald Geyer <harald@xxxxxxxxx> > Date: Tue, 13 Feb 2018 14:43:08 +0000 > Subject: [PATCH] regulator: dt: regulator-name is required property > > These two drivers fail to probe if no name is provided. For details see: > https://www.spinics.net/lists/kernel/msg2457515.html > > Signed-off-by: Harald Geyer <harald@xxxxxxxxx> > Acked-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Mark Brown <broonie@xxxxxxxxxx> What about using the DT node name instead, as is done for single-output clocks? > --- > Documentation/devicetree/bindings/regulator/fixed-regulator.txt | 1 + > Documentation/devicetree/bindings/regulator/gpio-regulator.txt | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt b/Documentation/devicetree/bindings/regulator/fixed-regulator.txt > index 4fae41d54798..0c2a6c8a1536 100644 > --- a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.txt > @@ -2,6 +2,7 @@ Fixed Voltage regulators > > Required properties: > - compatible: Must be "regulator-fixed"; > +- regulator-name: Defined in regulator.txt as optional, but required here. > > Optional properties: > - gpio: gpio to use for enable control > diff --git a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt > index dd1ed789728e..1f496159e2bb 100644 > --- a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt > @@ -2,6 +2,8 @@ GPIO controlled regulators > > Required properties: > - compatible : Must be "regulator-gpio". > +- regulator-name : Defined in regulator.txt as optional, but required > + here. > - states : Selection of available voltages and GPIO configs. > if there are no states, then use a fixed regulator Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
