On 15/02/2018 at 07:27:47 +0000, Denis OSTERLAND wrote: > Am Mittwoch, den 14.02.2018, 21:26 +0100 schrieb Alexandre Belloni: > > On 23/01/2018 at 13:17:58 +0100, Michael Grzeschik wrote: > > > > > > From: Denis Osterland <Denis.Osterland@xxxxxxxxx> > > > > > > After successful > > > sr = isl1208_i2c_set_regs(client, 0, regs, ISL1208_RTC_SECTION_LEN); > > > sr will be 0. > > > As a result > > > sr = i2c_smbus_write_byte_data(client, ISL1208_REG_SR, > > > sr & ~ISL1208_REG_SR_WRTC); > > > is equal to > > > sr = i2c_smbus_write_byte_data(client, ISL1208_REG_SR, 0); > > > which clears all flags in SR. > > > > > > Add an additional read of SR, to have value of SR in sr again. > > > > > > Signed-off-by: Denis Osterland <Denis.Osterland@xxxxxxxxx> > > > Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx> > > > --- > > > drivers/rtc/rtc-isl1208.c | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > Applied, thanks. > > > You are welcome. > > One question, shall we avoid resent this patch in v2 of this series? > I ask because we are pretty far with the suggested changes. > No need to resend. If necessary, you can base v2 on top of rtc-next. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
