Icenowy, On Mon, Feb 12, 2018 at 12:26 AM, André Przywara <andre.przywara@xxxxxxx> wrote: > Hi, > > On 03/02/18 15:49, Icenowy Zheng wrote: >> Allwinner H6 is a new SoC with Cortex-A53 cores from Allwinner, with its >> memory map fully reworked and some high-speed peripherals (PCIe, USB >> 3.0) introduced. >> >> This commit adds the basical DTSI file of it, including the clock >> support and UART support. > > Checked the MMIO addresses and the interrupt numbers against the manual. > >> Signed-off-by: Icenowy Zheng <icenowy@xxxxxxx> > > Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx> > > Thanks! > Andre. > >> --- >> Changes in v2: >> - Add APB1 clock as PIO's APB clock. >> - Switched to SPDX license identifier. >> >> arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 178 +++++++++++++++++++++++++++ >> 1 file changed, 178 insertions(+) >> create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi >> new file mode 100644 >> index 000000000000..d4697bb42496 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi >> @@ -0,0 +1,178 @@ >> +/* >> + * Copyright (C) 2017 Icenowy Zheng <icenowy@xxxxxxx> >> + * >> + * SPDX-License-Identifier: (GPL-2.0+ or MIT) >> + */ Thank you for using SPDX ids: this needs to be on the first line though! [1] and eventually some special comments style. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html